Getting [object Object] for custom error, not being reported by AVA

Description

Custom error when returning a promise inside the test is returning a non descriptive error. When doing a console.log on the rejected promise, I can see the ValidationError name from Joi.

The error should show as: ValidationError: child "uuid" fails because ["uuid" with value "f47ac10b-58cc-x372-a567-0e02b2c3d479" fails to match the required pattern: /[0-9A-F]{8}-[0-9A-F]{4}-4[0-9A-F]{3}-[89AB][0-9A-F]{3}-[0-9A-F]{12}/i]

Test Source

// index.js
import * as Joi from 'joi'
import * as bluebird from 'bluebird'

export const schema = Joi.object().keys({
  fullname: Joi.string()
    .description('validar nome completo')
    .min(5)
    .regex(/\s{1}/)
})

export function validate(obj) {
  return bluebird.fromCallback((resolver) => {
    Joi.validate(obj, schema, resolver)
  })
}

// test/index.test.js

import test from 'ava'
import * as validation from '../index'

const valid = (obj, t) => {
  return validation.validate(obj).then((c) => {
    t.pass(c)
  })
}

const ValidationError = (e) => e.name === 'ValidationError'

test('uuid', (t) => {
  t.plan(3)

  return valid({
    uuid: 'f47ac10b-58cc-x372-a567-0e02b2c3d479' //should fail ava on purpose, change x to 4 to pass
  }, t).then(() => valid({
    uuid: '123e4567-e89b-12d3-a456-426655440000'
  }, t)).catch(ValidationError, (c) => { // c is ValidationError, so it passes
    t.pass()
  }).then(() => valid({
    uuid: 'a'
  }, t)).catch(ValidationError, (c) => { // c is ValidationError, so it passes
    t.pass()
  })
})

Error Message & Stack Trace

> ava test/*.test.js --verbose

  × uuid Planned for 3 assertions, but got 2.

  1 test failed [19:01:55]


  1. uuid
  [object Object]
    Test.fn (index.test.js:13:5)

Command-Line Arguments

ava test/*.test.js --verbose

Environment

Node.js v6.9.1
win32 10.0.14393
npm 4.0.1
ava 0.16.0

[novemberborn]

t.fail() will cause your test to fail right away. Which is appropriate for unwanted rejections.

Perhaps try:

test('uuid', async t => {
  const first = await t.throws(validation.validate({ uuid: 'f47ac10b-58cc-x4372-a567-0e02b2c3d479' }))
  t.true(first.name === 'ValidationError')

  t.notThrows(validation.validate({ uuid: '123e4567-e89b-12d3-a456-426655440000' }))
  t.notThrows(validation.validate({ uuid: 'a' }))
})

t.throws() and t.notThrows() work with promises, too.

[vadimdemedes]

Closing due to inactivity.

@pocesar feel free to reply back whenever you have time and we’ll reopen the issue 😉