t.notThrows(promise) should return an "empty" promise

This is as expected:

const value = Symbol()
t.notThrows(() => value) === undefined

However:

const value = Symbol()
(await t.notThrows(Promise.resolve(value))) === value

t.notThrows(promise) should return a promise, but for an undefined value.

The offending line is at https://github.com/avajs/ava/blob/dcdfbee689e1538420f5793bbaca09c7e78ddedd/lib/assert.js#L124.

The Flow and TypeScript definitions should be updated too:

• https://github.com/avajs/ava/blob/dcdfbee689e1538420f5793bbaca09c7e78ddedd/index.js.flow#L63
• https://github.com/avajs/ava/blob/dcdfbee689e1538420f5793bbaca09c7e78ddedd/types/base.d.ts#L68

[novemberborn]

IMO the parallel should be with the the form of notThrows that is passed a function:

const val = t.notThrows(() => ({foo: 'bar'}))
t.deepEqual(val, {foo: 'bar'})

Is that a sensible thing to do, or is it not? Currently it doesn’t work, and we should resolve that inconsistency one way or the other.

[sindresorhus]

I would rather say:

const prom = getProm();
await t.notThrows(prom);
t.is(typeof (await prom), 'string');

vs

const val = await t.notThrows(getProm());
t.is(typeof val, 'string');

I think the former, while a tiny bit more verbose, is much clearer.