Can't properly disable focused controls

Describe the bug Some key events are still fully functional in disabled+focused controls. Probably related to https://github.com/AvaloniaUI/Avalonia/issues/6957, but the PR does not solves other controls. With Fluent theme, control style don’t get updated. But I can see in the debugger that IsEnabled is already set to false.

To Reproduce

1. Make TextBox focus
2. Disable the TextBox
3. Start typing…

FocusedControlsIssue.zip

Expected behavior Disabled controls should not accept key events.

Screenshots

https://user-images.githubusercontent.com/57059775/147838556-cb1a0b3b-227a-4784-ae87-041aa0ad19d0.mp4

Desktop (please complete the following information):

• OS: Debian (dwm)
• Version: 0.10.10

[chkr1011]

In WPF a control is no longer interactive when it is disabled (IsEnabled=false). The focus will be lost. This can also lead to a null value for the current focused element when the current keyboard focus “holder” gets disabled by a binding etc.

I am dealing with a similar issue in Avalonia. I have disabled controls but unfortunately I can still access them via Ctrl+Tab including changing is values via keyboard. In my opinion this is a bug. Why should I disable the control in the first place when interacting with them is still possible?

Avalonia works correct when the “IsEnabled” state is set in the AXAML file directly. Then no interaction is possible. But setting it later (or at container level) will lead to a “half disabled” control. Visually it is but from interaction perspective it is not.

[robloo]

Seems to be a fairly fundamental issue. I’m surprised it has so far gone unnoticed except for the special cases. I see lots of examples:

https://github.com/AvaloniaUI/Avalonia/pull/6632 https://github.com/AvaloniaUI/Avalonia/pull/7206