ColorPicker Color property doesn't work

Describe the bug When modifying the Color property manually, the color of the ColorPicker doesn’t change However, when modifying the HsvColor property, the color changes correctly

I found in the xml that the ColorPicker uses the HsvColor property to draw its Background. This property should automatically change when the Color property changes, but this is not happening because the ignorePropertyChanged is set to true for the ColorPicker

To Reproduce Create a ColorPicker and change its Color

ColorPicker colorPicker = new ColorPicker();
colorPicker.Color = new Color(255, 255, 0, 0);

Expected behavior The color of the ColorPicker (and the ColorView popup) should change

Desktop (please complete the following information):

• OS: Ubuntu 22.04
• Version 11.0-preview1

[timunie]

Thanks for the background you gave. Makes sense to me. But you may be right about the lifecycle thing.

[robloo]

I have a fix for this that is the lesser of two evils. It will be included with #9140.

What it does is switch the main processing from the ColorView hosted in the control template to the ColorPicker itself. This works-around lifetime limitations with how the control is created (and the template applied, I got lazy trying to make the control as simple as possible and overlooked this). As a side-effect, a new property for IsHostedInColorPicker is added – that’s the lesser of two evils. I normally don’t like properties like this but the alternative was to attempt to pass control back-and-forth between the ColorPicker and ColorView based on when the template is applied. That is potentially error-prone and is likely difficult to maintain.

Also see the discussion here: https://github.com/AvaloniaUI/Avalonia/discussions/9128