FindControl returns null for UserControl

Hi,

I’ve updated to the latest CI build that uses XAMLIL.

Now the FindControl if used inside the ctor returns null for UserControl example:

    public ImageColorReplacePage()
    {
        this.InitializeComponent();
        this.Initialized += (s, e) =>
        {
            // FindControl after the Initialization is complete works
            var thisWontBeNull = this.FindControl<KitItemInformationView>("kitView");
        };

        // FindControl within the Constructor won't find anything
        var thisOneWillBeNull = this.FindControl<KitItemInformationView>("kitView");
    }

Repro project: https://github.com/braca/avalonia-findcontrol-bug

[Kermalis]

For anyone who wants a workaround, here’s a method you can use:

        private void Find()
        {
            //var thing = this.FindControl<MyUserControl>("TheName");
            var thing = this.TemporaryFix<MyUserControl>("TheName");
        }

        // Temporary fix for https://github.com/AvaloniaUI/Avalonia/issues/2562
        private T TemporaryFix<T>(string name) where T : UserControl
        {
            T Recursion(System.Collections.Generic.IEnumerable<Avalonia.LogicalTree.ILogical> list)
            {
                foreach (Avalonia.LogicalTree.ILogical i in list)
                {
                    if (i is Avalonia.INamed named && named is T ret && ret.Name == name)
                    {
                        return ret;
                    }
                    else
                    {
                        T r = Recursion(i.LogicalChildren);
                        if (r != null)
                        {
                            return r;
                        }
                    }
                }
                return null;
            }
            return Recursion(this.LogicalChildren);
        }

You would put TemporaryFix<T>() in your class since this.LogicalChildren is actually protected for UserControls. You could put it in some utils class if you pass this.LogicalChildren as another parameter instead.

[Slxdy]

Should be fixed by #2705

Unfortunately, it isn’t #8231