Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`ICompositionImportedGpuImage.ImportCompeted` should be called `ImportCompleted`

See original GitHub issue

Describe the bug Here is the interface ICompositionImportedGpuImage:

https://github.com/AvaloniaUI/Avalonia/blob/81d455762d4b5dc49eab425898afd81ca131b99c/src/Avalonia.Base/Rendering/Composition/CompositionExternalMemory.cs#L87-L99

The member ImportCompeted should be called ImportCompleted.

To Reproduce See the above source code.

Expected behavior The member ImportCompeted should be called ImportCompleted.

Screenshots N/A

Desktop (please complete the following information):

OS: Linux (ArcoLinux), KDE/Wayland
Version 11.0.0-rc1.1

Issue Analytics

State:
Created 3 months ago
Reactions:2
Comments:10 (10 by maintainers)

Top GitHub Comments

3reactions

hez2010commented, Jul 8, 2023

@maxkatz6 Note that netstandard2.0 doesn’t support interface default implementation, so adding a member to the interface will result in binary breaking change as well. So you are in a situation that either fix is introducing breaking change unless you don’t fix it forever. I searched the entire GitHub using ImportCompeted, seems that currently no one is using it except Avalonia and its fork: https://github.com/search?q=ImportCompeted&type=code My suggestion is to fix it now before people actually start to use it, and a release 11.0.1 ASAP, then mark 11.0.0 nuget package as obsoleted. Only in this way can we minimize the impact.

1reaction

jgcodes2020commented, Jul 9, 2023

@kekekeks is it OK if I obsolete ImportCompeted?