Memory leak in master branch (automation related?)

Describe the bug The latest master branch (tested 0.10.999-cibuild0020870-beta https://github.com/AvaloniaUI/Avalonia/commit/cea6bc27a06f25b4f2d3a73d3411e904b1767e74) has a memory leak, probably related to Automation code.

Note: this is a regression from the current stable 0.10.x version (which doesn’t have automation related modules).

To Reproduce The repro is very simple - just add a button, press it and the button will not be freed anymore.

1. Clone the repo: https://github.com/BAndysc/AvaloniaMenuLeak
2. Checkout branch leak2
3. Run the app
4. The top text shows managed used memory, in the beginning it is less than 3 MBs
5. Press the button Add control
6. This will spawn a control, that has a reference to 1GB byte array, so obviously the ram usage will rise up to 1 GB
7. Press Remove Control
8. GC will free the control and datacontext almost instantly, and it will go down to 3 MBs, so far so good.
9. Press Add control again
10. This time click the button ‘Click me’
11. Press Remove control
12. Notice this time the memory usage doesn’t drop. The control is not freed!

Screenshots dotMemory screenshot:

Desktop:

• OS: Mac
• Version: 0.10.999-cibuild0020870-beta (it works fine on 0.10.14)

[maxkatz6]

Yeah, reproduced using Accessibility Insights to trigger automation. Got three weak references that live after button was detached:

[BAndysc]

Pretty weird, I used dotMemory as well to fix previous memory leak, and I used latest master (well, couple of days old now). And there was only one memory leak with old sample code.

if you mean my sample code, then the previous one (menu related) didn’t have this button, I’ve discovered it accidentally, while trying to reproduce another leak