question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

The CaptionButtons control spells Minimize and Maximize inconsistently

See original GitHub issue

I was theming the CaptionButtons class and noticed that there is inconsistent spelling of “Minimize” (currently “Minimise”) and “Maximize” (currently “Maximise”), even in a PART name.

It would be ideal to stick with the US English version of the words instead of the British English version since those are what WPF is based on, and your pseudoclasses (:minimized, :maximized) and WindowState types are already using them.

Part Name

[TemplatePart("PART_MinimiseButton",   typeof(Button))]

Should be:

[TemplatePart("PART_MinimizeButton",   typeof(Button))]

There are other variables that need to be renamed in the CaptionButtons class source as well.

AutomationProperties.Name

The AutomationProperties.Name assigned in templates like in the Simple theme is using the British English version instead of the US English version.

Summary

This is a quick change but one that should be made for consistency.

Issue Analytics

  • State:closed
  • Created 4 months ago
  • Reactions:2
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
billhenncommented, May 13, 2023

@robloo - The changes in the PR look good.

1reaction
timuniecommented, May 11, 2023

This is a quick change but one that should be made for consistency.

I think this is also a breaking change, so should be done now or never.

@AvaloniaUI/core are we happy with such a PR at the current stage?

Read more comments on GitHub >

github_iconTop Results From Across the Web

What's New in the Latest Version - Actual Title Buttons
Window Actions, Title Buttons: The Resize Window title button disappeared after minimizing/restoring a window. [-] Window Actions, Title Buttons: The Align ...
Read more >
Viewing online file analysis results for 'ammsetup.exe'
Submit malware for free analysis with Falcon Sandbox and Hybrid Analysis technology. Hybrid Analysis develops and licenses analysis tools to fight malware.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found