Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove dependency step in order to use the extension

See original GitHub issue

coda_hale commented this in reddit

Looks like a great start, and it’s awesome to see more high-quality support for Clojure! One quick note: I’m pretty sure you can get around the manual cider-nrepl/nrepl dependencies steps if you invoke lein the same way cider does:
/usr/local/bin/lein update-in :dependencies conj \
  \[org.clojure/tools.nrepl\ \"0.2.12\"\ \:exclusions\ \
  \[org.clojure/clojure\]\] -- update-in :plugins conj \
  \[refactor-nrepl\ \"2.3.0-SNAPSHOT\"\] -- update-in :plugins conj \
  \[cider/cider-nrepl\ \"0.15.0-SNAPSHOT\"\] -- repl :headless
That also means you’re not tied down to a particular version of those libraries.

Issue Analytics

State:
Created 7 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

1reaction

fasfsfgscommented, Jul 12, 2017

I see. But if we don’t ask for parameters, we prevent them from connecting to a remote REPL for example.

I think we should clearly distinct between the 2 connection modes. I think this will avoid confusion when using them and also simplify the logic.

Here are the commands I was thinking to provide:

Start REPL Automatically start and connect to a REPL. This is the main command we want to provide in this issue. This would always start a new REPL, even if the user started one himself outside the extension. If the user already started a REPL using this command, we prevent them from creating a new one (message: REPL already started). If they are connected manually to a REPL, we ask them to disconnect first.
Connect to a running REPL This is the today’s connection mode. We continue to ask for parameters. But I was thinking about removing automatic connection in case the user has a running REPL in the same path as the project. We can always help the user fill the parameters if we find a running REPL. This would continue to keep #31 a good requirement. If they are already connected to a REPL, we ask them to disconnect first.
Stop/disconnect REPL We kill the REPL we started in Start REPL. If the user connected manually, we stop using the parameters informed.

When the user opens a clojure project, I think we should always do a Start REPL. If they want to manually connect to a running REPL, they’d have to disconnect first. And later, like you said, we can leverage vscode project settings to change this default behavior.

0reactions

fasfsfgscommented, Jul 13, 2017

Great! Thanks! I’ll follow those ideas then. I’ll let you know if I get stuck in some case.