Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Insanity check] Refactor ImportActivity

See original GitHub issue

Existing activity does actually work, but its implementation is beyond all redemption

TODO

List all use cases
List all interactions (~~dirpicker~~, SAF system dialog, import service)
List all inputs and outputs
Rewrite the whole process from scratch; try and make something STATELESS

HIGHLIGHTS

~~Remove the dirpicker; file selection should be done exclusively with the SAF dialog~~ DONE v1.9.0
Replace deprecated ProgressDialog with something clean and modal (i.e. that cannot be accidentally dismissed, leaving the user blind)
Refresh / import progress should also appear on a notification, for users to check it when the app runs in background

Issue Analytics

State:
Created 4 years ago
Comments:6 (1 by maintainers)

Top GitHub Comments

1reaction

avluiscommented, Jun 15, 2019

In relation to #191 I remember coming to the same conclusion above – saving files to a world readable directory is bad for management and security. I think I even threw in a few utility classes as well as a zip utility; Try selecting a book by pressing and holding the entry in Downloads – the third option (Archive) packs the files and requests a share intent iirc

0reactions

RobbWatershedcommented, Apr 23, 2020

D.O.N.E.

Top Results From Across the Web

unit test via output sanity checks - Stack Overflow

A unit test focuses on the smallest possible amount of code. ... 3) How can one refactor existing code to be unit testable?...

Refactoring - Dive Into Python 3

This test used to call from_roman() with 'MMMM' and expect an error; now that MMMM is considered a valid Roman numeral, you need...

Refactor vulnerability report cluster filter - Merge requests

This MR refactors the cluster filter to detangle from the simple_filter.vue and instead use the new more basic querystring_sync.vue component.

@sanity/types | Yarn - Package Manager

Sweet APIs for reading, writing, importing, exporting, go back in time, and listening for updates. Secure, scalable and GDPR compliant. Zero config Graph ......

Migrate Separate ImportState Tests Into All Applicable Tests

Import acceptance test refactor for SSM resources #9957 ... Acceptance test import refactor for SFN activity #9960.