Awaitility hiding exceptions on the same thread

This is a small program that demonstrates the behavior I’m seeing that appears to be a bug.

Actual behavior: When this runs it exits and prints IllegalArgumentException stack trace like a normal java program. The weird behavior is if you comment out the line .dontCatchUncaughtExceptions(), it will exit with status code 1 and not print the exception.

Expected behavior: I would expect awaitility to not affect exceptions thrown in the same thread and outside its until() {} block.

Version: <groupId>org.awaitility</groupId> <artifactId>awaitility</artifactId> <version>3.1.2</version>

public static void main(final String... args) throws Exception {
        final AtomicInteger count = new AtomicInteger(0);
        await()
                .dontCatchUncaughtExceptions()
                .ignoreExceptionsMatching(instanceOf(IOException.class))
                .atMost(3, TimeUnit.MINUTES)
                .until(() -> {
                    count.incrementAndGet();
                    return count.get() > 3;
                });

        if (true) {
            System.out.println("throwing an exception");
            throw new IllegalArgumentException("broken");
        }
        System.out.println("Already exited so you won't see this");
}

[grofoli]

I opened a PR few minutes ago. Please be aware that writing a unit test similar to the main method below is not easily possible, because the JUnit Framework has an own Exception handling. Therefore I decided to test an implementation detail in the unit test, namely the reset of the original defaultUncaughtExceptionHandler.

The following main method throws an IllegalArgumentException exception, which proves that the Awaitility does NOT hide exception on the main thread anymore.

public static void main(final String... args) throws Exception {
        final AtomicInteger count = new AtomicInteger(0);
        await()
                .until(() -> {
                    count.incrementAndGet();
                    return count.get() > 3;
                });

        if (true) {
            throw new IllegalArgumentException("broken");
        }
    } 

[johanhaleby]

Thanks for trying it out, reviewing and reminding me Oliver! 😃 I’ll try release 4.0.2 now. I can’t thank you enough for your efforts on this release!

On Thu, Jan 2, 2020 at 8:38 PM Oliver Grof [e-mail] wrote:

@johanhaleby https://github.com/johanhaleby I tried a little bit some simple usages of the libary today and they were working fine. When do you plan to release it? FYI: There is a PR open that I reviewed and suggested a minor change for @metatype https://github.com/metatype. Do you want to include that in the next version as well or do you want to release the current 4.0.2-SNAPSHOT? #153 https://github.com/awaitility/awaitility/pull/153

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/awaitility/awaitility/issues/152?email_source=notifications&email_token=AABNVFLQFBVIADPUE7LLXPDQ3Y7C5A5CNFSM4J2D2PHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7F5NI#issuecomment-570318517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABNVFINQ4OKQRSYBDZC3P3Q3Y7C5ANCNFSM4J2D2PHA .