modelgen bug with Has One @connection relation with an explicit field

Describe the bug Related to this issue in JS: https://github.com/aws-amplify/amplify-js/issues/6560

amplify codegen models is incorrectly handling Has One relations. The associatedWith field is not being set to the field specified in the fields argument.

The following model:

type Project @model {
  id: ID!
  name: String
  teamID: ID!
  team: Team @connection(fields: ["teamID"])
}

Gets modelgen’d to

"Project": {
    "name": "Project",
    "fields": {
        "id": {
            "name": "id",
            "isArray": false,
            "type": "ID",
            "isRequired": true,
            "attributes": []
        },
        "name": {
            "name": "name",
            "isArray": false,
            "type": "String",
            "isRequired": false,
            "attributes": []
        },
        "teamID": {
            "name": "teamID",
            "isArray": false,
            "type": "ID",
            "isRequired": true,
            "attributes": []
        },
        "team": {
            "name": "team",
            "isArray": false,
            "type": {
                "model": "Team"
            },
            "isRequired": false,
            "attributes": [],
            "association": {
                "connectionType": "HAS_ONE",
                "associatedWith": "id"
            }
        }
    },
    "syncable": true,
    "pluralName": "Projects",
    "attributes": [
        {
            "type": "model",
            "properties": {}
        }
    ]
},

Amplify CLI Version 4.29.2

To Reproduce Run amplify codegen models on the following schema:

type Project @model {
  id: ID!
  name: String
  teamID: ID!
  team: Team @connection(fields: ["teamID"])
}

type Team @model {
  id: ID!
  name: String!
}

Expected behavior I would expect that team: Team @connection(fields: ["teamID"]) should result in:

"team": {
    "name": "team",
    "isArray": false,
    "type": {
        "model": "Team"
    },
    "isRequired": false,
    "attributes": [],
    "association": {
        "connectionType": "HAS_ONE",
        "associatedWith": "teamID"
    }
}

[AaronZyLee]

I just find an interesting thing on the difference between BELONGS_TO and HAS_ONE. According to this post, it says

To determine who “has” the other object, look at where the foreign key is. We can say that a User “has” a Profile because the profiles table has a user_id column.

After checking the amplify docs, this is the case for A HAS_MANY Bs and B BELONGS_TO A. In contrast, BELONGS_TO is not mentioned in HAS_ONE section. If we take the prerequisite above, we can find that Team actually HAS_ONE Project and Project BELONGS_TO Team, which is just the opposite to the current output.

Hence, I think the correct output should result in:

"team": {
    "name": "team",
    "isArray": false,
    "type": {
        "model": "Team"
    },
    "isRequired": false,
    "attributes": [],
    "association": {
        "connectionType": "BELONGS_TO",
        "targetName": "teamID"
    }
}

[github-actions[bot]]

This issue has been automatically locked since there hasn’t been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.