Multi environment lambda layer hard codes environment

Describe the bug I have two environments and have created a new lambda layer. When I add the lambda layer to a function in the first environment, the CFN template for that function injects the current environment’s layer value as a hard coded value from the env it was created in, rather than the environment that the build is/will be occurring in

https://github.com/aws-amplify/amplify-cli/blob/bffaded7351e3bfbcb67fede139b3dab7770eda4/packages/amplify-category-function/src/provider-utils/awscloudformation/utils/lambda-layer-cloudformation-template.ts#L154-L158

Amplify CLI Version 4.29.4

To Reproduce

1. Create two environments
2. Add a single lambda layer to both
3. Add the lambda layer to a function in environment A
4. Check the output of Layers in function-cloudformation-template.json – the value contains a hard-coded env

Expected behavior The string value should contain a reference to Ref:env to pull the environment value from the current build environment rather than the environment where the layer was added to the function

Desktop (please complete the following information):

• OS: Mac
• Node Version. 10.15.3

Additional context

https://github.com/aws-amplify/amplify-cli/blob/bffaded7351e3bfbcb67fede139b3dab7770eda4/packages/amplify-category-function/src/provider-utils/awscloudformation/utils/lambda-layer-cloudformation-template.ts#L154-L158

[tomhirschfeld]

@jhockett anything else to share here? Layers are really slowing our productivity down

[jhockett]

Hi all, we are actively looking into reworking how layer versions work in the CLI, so fixing this issue will likely either coincide or follow that update.