question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[@aws-cdk/aws-appmesh] AppMesh Stable Changes

See original GitHub issue

AppMesh API Revisions

  1. Currently VirtualNode defaults the value of the logging file path parameter to /dev/stdout and is not configurable through the construct’s props. Remove this default and allow customers to configure log location for their specific use case.

  2. Change addListeners method signature to not be variadic since VirtualNode only has one listener. Depending on https://github.com/aws/aws-app-mesh-roadmap/issues/120 we may or may not actually want to change this API.

  3. Change model so that VirtualService always uses mesh from either router or node and requires mesh property to exist on VirtualRouter and VirtualNode for importing. VirtualNode and VirtualRouter always have to be in same mesh as VirtualService.


This is 🐛 Bug Report

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:11 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
dfezziecommented, Nov 24, 2020

Ah good call on 2. That is complete 😄

For 3, I think adding that enforcement is valid and would prevent customers misconfiguring their mesh. If it makes sense in terms of CDK API design we could easily implement it.

I agree on the switching the VirtualService to using a union type for the provider. I just took a quick look and we are also doing something similar for VirtualNode service discovery where we accept CloudMap and DNS at the top level. We should change that as well!

0reactions
github-actions[bot]commented, Jan 28, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

Read more comments on GitHub >

github_iconTop Results From Across the Web

aws-cdk/aws-appmesh module - AWS Documentation
App Mesh standardizes how your microservices communicate, giving you end-to-end visibility and helping to ensure high-availability for your applications. App ...
Read more >
aws-cdk.aws-appmesh · PyPI
The APIs of higher level constructs in this module are in developer preview before they become stable. We will only make breaking changes...
Read more >
aws app mesh with cdk in 5 steps - DEV Community ‍ ‍
I've prepared two microservices with a small react app that polls two endpoints. BFF Architecture. let's clone the GitHub repository. git clone ...
Read more >
What's new with AWS CloudFormation and AWS CDK
Libraries from “experimental” or. “developer preview” to “stable”. AWS CDK LAYER 2. Amazon CodeGuru. AWS App Mesh. Amazon DocumentDB. Amazon OpenSearch.
Read more >
App Mesh visibility | Nick's Awesome Cloud Blog
AWS App Mesh leverages Envoy for its data plane. ... cd appmesh-visibility-cdk $ npm install $ npx cdk@1.19.0 deploy --require-approval ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found