(aws-ec2): addS3DownloadCommand does not work in China, opt-in regions

Use Case

Currently, AWS China region need aws s3 cp --region cn-north-1 to be able to download file from s3

https://github.com/aws/aws-cdk/blob/3530e8c758df3ea2fb26d654109e17a75f157b37/packages/%40aws-cdk/aws-ec2/lib/user-data.ts#L159

Proposed Solution

export interface S3DownloadOptions {

  /**
   * Name of the S3 bucket to download from
   */
  readonly bucket: IBucket;

  /**
   * The key of the file to download
   */
  readonly bucketKey: string;

  /**
   * The name of the local file.
   *
   * @default Linux   - /tmp/bucketKey
   *          Windows - %TEMP%/bucketKey
   */
  readonly localFile?: string;

  /**
   * The region to use
   */
  readonly region?: string;
}

  public addS3DownloadCommand(params: S3DownloadOptions): string {
    const s3Path = `s3://${params.bucket.bucketName}/${params.bucketKey}`;
    const localPath = ( params.localFile && params.localFile.length !== 0 ) ? params.localFile : `/tmp/${ params.bucketKey }`;
    this.addCommands(
      `mkdir -p $(dirname '${localPath}')`,
      `aws s3 cp --region '${params.region ?? stack.region}' '${s3Path}' '${localPath}'`,
    );

    return localPath;
  }

• 👋 I may be able to implement this feature request
• ⚠️ This feature might incur a breaking change

---

This is a 🚀 Feature Request

[rix0rrr]

I guess it’s only accidental that the other commands even work 😦 .

A better fix would have been to set AWS_REGION at the start of UserData, but that’s probably a change we can’t make anymore. Adding in the --region parameter seems like the best solution.

[github-actions[bot]]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.