(aws-ecs): adding cluster config disables container insights

What is the problem?

ECS Cluster container insights gets disabled, even if the cdk stack settings is set to true.

Reproduction Steps

Created a minimal reproducible example at https://github.com/rajyan/cdk-ecs-bug.

First, deploy a cluster with containerInsights: true only.

import * as cdk from '@aws-cdk/core';
import * as ecs from '@aws-cdk/aws-ecs';

export class CdkEcsBugStack extends cdk.Stack {
  constructor(scope: cdk.Construct, id: string, props?: cdk.StackProps) {
    super(scope, id, props);

    new ecs.Cluster(this, 'Cluster', {
      containerInsights: true,
    });
  }
}

Then deploy the cluster adding executeCommandConfiguration, leaving containerInsights: true.

import * as cdk from '@aws-cdk/core';
import * as ecs from '@aws-cdk/aws-ecs';

export class CdkEcsBugStack extends cdk.Stack {
  constructor(scope: cdk.Construct, id: string, props?: cdk.StackProps) {
    super(scope, id, props);

    new ecs.Cluster(this, 'Cluster', {
      containerInsights: true,
      executeCommandConfiguration: {
        logging: ecs.ExecuteCommandLogging.OVERRIDE,
        logConfiguration: {
          cloudWatchLogGroup: new LogGroup(this, 'LogGroup'),
        }
      },
    });
  }
}

What did you expect to happen?

Only executeCommandConfiguration should be added to the cluster, and no changes in containerInsights.

What actually happened?

Container insights got disabled.

CDK CLI Version

1.134.0

Framework Version

No response

Node.js Version

v16.13.0

OS

Both on Linux and maxOS

Language

Typescript

Language Version

TypeScript (3.9.7)

Other information

Also confirmed that deploying these two settings at once won’t disable container insights.

[rajyan]

@ryparker

The “needs-reproduction” label was just a temporary marker that means we haven’t verified the reproduction.

I’m sorry to hurry you.

Thank you very much for your investigation!

[ryparker]

Handling this internally. I’ll follow up in this thread when we have updates to share.