(aws-ecs-patterns): X-Ray support

Please make it trivial to add the xray side-car for aws-ecs-patterns/ApplicationLoadBalancedFargateService etc.

Use Case

I want to encourage my developers to use X-Ray, to do this, I want to make it stupid easy to deploy X-Ray enables services.

Proposed Solution

    const service = new ecsp.ApplicationLoadBalancedFargateService(this, 'service', {
       ...
       xraySidecar: true
    };

Where that runs something like https://github.com/aws-samples/one-observability-demo/blob/d11387bba7640f97dc42b01bb07f0d53cd98c8d7/PetAdoptions/cdk/pet_stack/lib/services/ecs-service.ts#L157

    // Enable xray side-car
    service.taskDefinition
      .addContainer('xraydemon', {
        image: ecs.ContainerImage.fromRegistry('public.ecr.aws/xray/aws-xray-daemon:latest'),
        memoryLimitMiB: 256,
        cpu: 256,
      })
      .addPortMappings({
        containerPort: 2000,
        protocol: ecs.Protocol.UDP,
      });

Other

• 👋 I may be able to implement this feature request
• ⚠️ This feature might incur a breaking change

---

This is a 🚀 Feature Request

[AndrewGuenther]

@SoManyHs I would push back on X-ray being considered advanced usage. It is a very common pattern across CDK constructs to have a boolean “Tracing enabled” option. Yes, I know that this isn’t a checkbox option with ECS, but I think it is still a fair consideration. Tracing is considered a well-architected best practice and should be made as easy as possible. I really think including it in ecs-patterns should be reconsidered. If ecs-patterns won’t follow well-architected practices out of the box, then I’d strongly encourage the entire module be deprecated in favor of Service Extensions.

[ahammond]

@SoManyHs I see your point. From my perspective x-ray support is an implementation detail and what I’m trying to do is run a container in fargate. The same way that adding x-ray support to a lambda is a one-liner, https://docs.aws.amazon.com/cdk/api/latest/docs/aws-lambda-readme.html#lambda-with-x-ray-tracing it seems to me that adding x-ray support to an ECS Service ought to be a one-liner.