Create route53 target for ec2.Instance

🚀 Feature Request

General Information

• 👋 I may be able to implement this feature request

• ⚠️ This feature might incur a breaking change

Description

It would be great to have a route53 target, now that we have an ec2.Instance construct. There should be a possibility to select between the public ip or private ip.

Proposed Solution

Something like this would be nice:

import route53 = require("@aws-cdk/aws-route53");
import targets = require("@aws-cdk/aws-route53-targets");
...
    const dnsRecord = new route53.ARecord(this, "ARecord", {
      recordName: `windows-bastion.${props.hostedZone.zoneName}`,
      zone: props.hostedZone,
      target: new targets.Ec2InstancePublicIpTarget(instance),
      target: new targets.Ec2InstancePrivateIpTarget(instance) // or
      target: new targets.Ec2InstanceTarget(instance, targets.Ec2InstanceTargetType.PUBLIC_IP)
    }

Environment

• CDK CLI Version: 1.8.0
• Module Version: 1.8.0
• OS: macOS Sierra
• Language: TypeScript

Other information

[kiros-sc]

Hello, I think it would be a really good feature, and why? I’m creating a cdk for the new vpn, creating a new recordSet for it, and I’ve already spent more than 2hours trying to get the record to match the EIP assign to the new instance.

I try with “route53.RecordTarget.fromValues” and “route53.RecordTarget.fromAlias” and nothing, in many cases the record was created ok, correct domainName, but the ip ha no idea where it was coming from. At the end this is the solution I found…

      const vpnDnsRecord = new route53.ARecord(this, "vpnDnsRecord", {
          recordType: RecordType.A,
          recordName: "vpn-xxx",
          zone: hostedZone,
          target: route53.RecordTarget.fromIpAddresses(vpnElasticIP.ref),
          ttl: Duration.seconds(60),
      });

Just so you understand: zone: hostedZone, >> I imported my hostedZone target: route53.RecordTarget.fromIpAddresses(vpnElasticIP.ref), >> I have a const “vpnElasticIP”. Honestly I don’t understand why that work and not the other test, and one thing that I already told in this tickets…

PLEASE IMPROVE CDK DOCUMENTATION (It’s not clear, no examples at all. I don’t want to be the bad person here, but look at terraform documentation to see what good docs are.)

[NGL321]

Hey @abelmokadem,

Sorry for the slow response, this seems like a reasonable feature to add. If you would like to implement it that would be a great contribution.

As for the particulars of the implementation, unfortunately I am not that familiar with the Route53 construct library. I recommend asking in the Gitter room. @shivlaks is the codeowner for the library.