Fifo queue without name in nested stack fails to create

Reproduction Steps

import cdk = require('@aws-cdk/core');

import { NestedStack } from '@aws-cdk/aws-cloudformation';
import { Queue } from '@aws-cdk/aws-sqs';

export class CdkFifoQueueStack extends cdk.Stack {
  constructor(scope: cdk.Construct, id: string, props?: cdk.StackProps) {
    super(scope, id, props);

    new MyNestedStack(this, 'NestedStack');
  }
}

export class MyNestedStack extends NestedStack {
  constructor(scope: cdk.Construct, id: string) {
    super(scope, id);

    new Queue(this, 'MyQueue', {
      fifo: true
    });
  }
}

source

MUST USE cdk deploy. THE STACK SYNTHESIZES FINE.

Error Log

CloudFormation error after running cdk deploy:

The name of a FIFO queue can only include alphanumeric characters, hyphens, or underscores, must end with .fifo suffix and be 1 to 80 in length. (Service: AmazonSQS; Status Code: 400; Error Code: InvalidParameterValue; Request ID: 0079e079-6bf5-5eec-90d9-b6e4eebec170)

Environment

• CLI Version : 1.19.0
• Framework Version: 1.19.0
• OS : macOS
• Language : TypeScript

---

This is 🐛 Bug Report

[nija-at]

How about setting the queueName to ${this.node.uniqueId.substr(0, 75)}.fifo when the fifo flag is set to true?

[NetaNir]

The queue name is it’s physical ID, when not required, the CDK will not set it, unless provided by the user. Setting a physical name for a resource have implication on the resource update policy, from CloudFormation docs:

If you specify a name, you can’t perform updates that require replacement of this resource. You can perform updates that require no or some interruption. If you must replace the resource, specify a new name.

Which is why we try to avoid setting a physical name for resources when not required. We will follow up with CloudFormation to see if this can be fixed on their side.

In the meantime we can implement @nija-at suggestion above.