Go: AppRunner - failed mapping between fields and types

❓ General Issue

The generated Go code doesn’t connect fields with the correct data types.

In the example below, the CfnServiceProps struct has a SourceConfiguration field, but this field is of type interface{} instead of the generated typeCfnService_SourceConfigurationProperty.

type CfnService_SourceConfigurationProperty struct {
	// `CfnService.SourceConfigurationProperty.AuthenticationConfiguration`.
	AuthenticationConfiguration interface{} `json:"authenticationConfiguration"`
	// `CfnService.SourceConfigurationProperty.AutoDeploymentsEnabled`.
	AutoDeploymentsEnabled interface{} `json:"autoDeploymentsEnabled"`
	// `CfnService.SourceConfigurationProperty.CodeRepository`.
	CodeRepository interface{} `json:"codeRepository"`
	// `CfnService.SourceConfigurationProperty.ImageRepository`.
	ImageRepository interface{} `json:"imageRepository"`
}

// Properties for defining a `AWS::AppRunner::Service`.
type CfnServiceProps struct {
	// `AWS::AppRunner::Service.SourceConfiguration`.
	SourceConfiguration interface{} `json:"sourceConfiguration"`
	// `AWS::AppRunner::Service.AutoScalingConfigurationArn`.
	AutoScalingConfigurationArn *string `json:"autoScalingConfigurationArn"`
	// `AWS::AppRunner::Service.EncryptionConfiguration`.
	EncryptionConfiguration interface{} `json:"encryptionConfiguration"`
	// `AWS::AppRunner::Service.HealthCheckConfiguration`.
	HealthCheckConfiguration interface{} `json:"healthCheckConfiguration"`
	// `AWS::AppRunner::Service.InstanceConfiguration`.
	InstanceConfiguration interface{} `json:"instanceConfiguration"`
	// `AWS::AppRunner::Service.ServiceName`.
	ServiceName *string `json:"serviceName"`
	// `AWS::AppRunner::Service.Tags`.
	Tags *[]*awscdk.CfnTag `json:"tags"`
}

This led me to (incorrectly) guessing at the config:

	awsapprunner.NewCfnService(stack, jsii.String("AppRunner"), &awsapprunner.CfnServiceProps{
		SourceConfiguration: &awsapprunner.CfnService_SourceConfigurationProperty{
			ImageRepository: &awsapprunner.CfnService_ImageRepositoryProperty{
				ImageIdentifier: image.ImageUri(),
				ImageConfiguration: &awsapprunner.CfnService_ImageConfigurationProperty{
					Port: jsii.String("80"),
				},
				ImageRepositoryType: jsii.String("ECR"),
			},
		},
	})

This resulted in incorrect SourceConfiguration and unexpected errors.

  AppRunner:
    Type: AWS::AppRunner::Service
    Properties:
      SourceConfiguration: {}
    Metadata:
      aws:cdk:path: CdkGoAppRunnerStack/AppRunner

I documented the correct way here: https://adrianhesketh.com/2021/06/14/go-cdk-app-runner/

Environment

• CDK CLI Version: 1.108.1
• Module Version: github.com/aws/aws-cdk-go/awscdk v1.108.0-devpreview
• Node.js Version: v14.15.5
• OS: MacOS
• Language (Version): Go

Other information

Suggest that:

• CfnService_SourceConfigurationProperty is renamed to remove the “CfnService_” prefix unless it’s required.
• CfnService_SourceConfigurationProperty is renamed to remove the “Property” prefix. Go structs don’t have properties, they have fields.

[peterwoodworth]

Marking this as a feature request. @MrArnoldPalmer should be able to give you a response soon

[github-actions[bot]]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.