Sam Package Requires S3 Bucket For PackageType: Image

I can confirm that the --s3-bucket and --s3-prefix have no use during sam package when using the PackageType: Image process with the --image-repository option. However when I remove the S3 options, the command won’t run. Can we remove that if indeed that is an oversight?

[bjfletcher]

It’s a bug in the aws-sam-cli code.

I’ve found that if template.yaml contains just AWS::Serverless::Function resources with PackageType: Image then it doesn’t complain asking for s3-bucket.

If however template.yaml contains non-function resources (e.g. AWS::Events::Rule) without PackageType: Image then it complains asking for s3-bucket. When I add PackageType: Image to these non-function resources, then it doesn’t complain asking for s3-bucket. (But sam deploy will then point out that these non-function resources shouldn’t have PackageType: Image.)

In short, aws-sam-cli code needs to be fixed to check PackageType only in the AWS::Serverless::Function resources.

[metaskills]

Yup, still seeing it. My sam package command is this.

sam package \
  --region "$AWS_DEFAULT_REGION" \
  --template-file ./.aws-sam/build/template.yaml \
  --output-template-file ./.aws-sam/build/packaged.yaml \
  --image-repository "$IMAGE_REPOSITORY"

And the error is this.

== SAM package...
Usage: sam package [OPTIONS]
Try 'sam package --help' for help.

Error: Missing option '--s3-bucket'

I’m using this cookiecutter. https://github.com/customink/lamby-cookiecutter/tree/master/{{cookiecutter.project_name}}