Dom lib required for TS to compile in Node app

Describe the bug

Dom lib required by typescript in order to successfully compile node app

Your environment

SDK version number

@aws-sdk/lib-dynamodb@3.36.0

Is the issue in the browser/Node.js/ReactNative?

Node.js

Details of the Node.js

v12.22.4

Steps to reproduce

• Create a fresh TS workspace
• Set minimal tsconfig.json and do not include “dom” in lib array
• Install @aws-sdk/lib-dynamodb@3.36.0
• import { DynamoDBDocumentClient } from "@aws-sdk/lib-dynamodb"; into hello world file
• run tsc to compile project

Observed behavior

The source code fails to compile with error:

Expected behavior

lib installed into node app should not require “dom” types to compile

Additional context

If you add “dom” to lib array in tsconfig.json, source code will compile successfully

[simonbuchan]

Getting typescript isomorphic code to compile without assertions across environments generally sucks, but in the public interface looks something like:

// Declare interfaces that will get merged with the real definitions in lib.dom and @types/node
declare global {
  export interface ReadableStream {}

  export namespace NodeJS {
    export interface Readable {}
  }

  // ...
}

export type InputStream = ReadableStream | NodeJS.Stream;

Really, it’s missing a typescript feature, maybe declare interface ReadableStream {} that evaluates to never if not otherwise defined?

[github-actions[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.