ReferenceError: ReadableStream is not defined

Describe the bug

If chunker.ts falls through a bunch of analysis cases it refers to the ReadableStream symbol, which is not imported or defined anywhere (and so is undefined):

https://github.com/aws/aws-sdk-js-v3/blob/28008c2a3e30cd234f447484d76777d5db56dad1/lib/lib-storage/src/chunker.ts#L22

A clear and concise description of what the bug is.

Your environment

SDK version number

@aws-sdk/lib-storage@3.13.1

Is the issue in the browser/Node.js/ReactNative?

Node

Steps to reproduce

import tar from 'tar';

        const source = tar.c({
          gzip: true,
          cwd: files.root,
        }, files.fileNames);

        const upload = new Upload({
          client: await this.s3(),
          queueSize: 4, // optional concurrency configuration
          leavePartsOnError: false, // optional manually handle dropped parts
          params: {
            Bucket: this.bucketName,
            Key: this.remoteDataKey(pv),
            Body: source,
          },
        });

Observed behavior

ReferenceError: ReadableStream is not defined

Expected behavior

Not this exception.

Additional context

To my mind a readable stream produced by the tar package should just work, but from the source in chunker.ts I can tell it’s not going to because that stream fails the type analysis.

Unfortunately this looks like it’s going to break with much of Node’s duck-typed ecosystem.

[garrett-hopper]

I just ran into this issue when using jszip which uses readable-stream. When @aws-sdk/lib-storage tried to check if the Body was a Readable, it was a different readable-stream instance of Readable rather than the Node.js Readable. Setting a READABLE_STREAM=disable environment variable (see readable-stream readable.js#L2) resolves this, however it doesn’t seem ideal. I’m not sure where the change should occur though. Should @aws-sdk/lib-storage check for the readable-stream instance?

@alexforsyth, can this issue be reopened?

[github-actions[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.