Needed to add args.push('--enable-features=NetworkService'); to overcome redirect to external vendor in auth workflow

Hello,

I am happy to make a pull request but could not commit to repo. This is very useful code and many of us here use it to login…

We had the issue described https://github.com/GoogleChrome/puppeteer/issues/1664 for a scenario where microsoft.com was sending a redirect to a vendor page to collect credentials.

We debugged with: DEBUG=aws-azure-login aws-azure-login --mode gui

The app freezes right after specifying the name in the first page. This I suppose is a common scenario. I am happy to create a pull request, the one open question is should this be a runtime flag or just always set, possibly this should always be set or only be set based on other user flags. Regardless, I am happy to create the pull request but was unable to as github denied me access to the repo so I decided to send as an issue then depending on how to resolve I will then fork the repo as suggested but seems cumbersome for a few lines of change.

git diff freeze_on_vendor_auth master diff --git a/lib/login.js b/lib/login.js index 376b3e8…0dda066 100644 — a/lib/login.js +++ b/lib/login.js @@ -332,7 +332,6 @@ module.exports = { try { const args = headless ? [] : [--app=${url}, --window-size=${WIDTH},${HEIGHT}]; if (disableSandbox) args.push(‘–no-sandbox’);

•        args.push('--enable-features=NetworkService');
  
         browser = await puppeteer.launch({
             headless,
  

[miguelfeitosa]

Hi Kenneth, Cool, thanks for reaching out. I believe this got solved and merged a while ago. Please go ahead and close… Thanks for the tool, we use it daily!!!

Miguel

On Tue, Oct 29, 2019 at 2:56 AM Kenneth Aasan [e-mail] wrote:

Hi @miguelfeitosa https://github.com/miguelfeitosa, You have to fork this repo to your own user, then submit a PR to this repo: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

Since this is an old issue I’ll close it soon unless you don’t send a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sportradar/aws-azure-login/issues/36?email_source=notifications&email_token=ABO53MKHQVT2VJQFMB5VXGTQQ7NCLA5CNFSM4FGZ7UQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECPODCQ#issuecomment-547283338, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABO53MOLNHSUDWXAUL67RNTQQ7NCLANCNFSM4FGZ7UQQ .

[kennethaasan]

Hi @miguelfeitosa, You have to fork this repo to your own user, then submit a PR to this repo: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

Since this is an old issue I’ll close it soon unless you don’t send a PR.