question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Extend Travis checks

See original GitHub issue

cfn-lint version: (cfn-lint --version) 0.14.0

Description of issue.

The Travis build check could be extended with aws cloudformation validate-template across the whole test/fixtures/templates/good folder, this was the good template are for sure good.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
kddejongcommented, Feb 18, 2019

I would also add the good templates shouldn’t be considered fully good. They are designed to test the rules and the rules are different scenarios (code coverage plays here). Usually it doesn’t mean the entire template is good That being said these probably could be restructured by rules and not under the idea of bad or good.

1reaction
kddejongcommented, Feb 18, 2019

I may be missing something here but aws cloudformation validate-template wouldn’t have caught the wrong value in EngineVersion.

Resources:
  AmazonMQConfiguration:
    Type: "AWS::AmazonMQ::Configuration"
    Properties:
      EngineType: "ACTIVEMQ"
      EngineVersion: "Bad 5.15.8"
      Name: "Configuration"
➜  aws cloudformation validate-template --template-body file://test3.yaml
{
    "Parameters": []
}
➜  echo $?                                                                                                                                 
0
Read more comments on GitHub >

github_iconTop Results From Across the Web

Speeding up the build
The XDebug extension is useful, if you wish to generate code coverage reports in your Travis builds, but it has been shown to...
Read more >
Continuous Integration part 2: Setting up Travis checks in Github
Setting up TravisCI status checks on a PR is easy. Here are a few steps to set up your Github repository PRs with...
Read more >
Extend Travis checks · Issue #663 · aws-cloudformation/cfn ...
The Travis build check could be extended with aws cloudformation validate-template across the whole test/fixtures/templates/good folder, ...
Read more >
Simple way to test your ext on TravisCI
Go to Travis Accounts, Sync the list of repositories, Enable your extensions repository; Copy the following files to your extension:.
Read more >
Secure your Travis CI releases – part 1: checksum with SHA
Because a hash code based on a secure hash function cannot be easily reproduced with a manipulated ZIP file as input, it can...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found