Conflict contract tests: contract_update_non_existent_resource and contract_update_create_only_property

Hey,

Our team is failing with contract test contract_update_non_existent_resource due it use contract_update_create_only_property test json file as previous resource model. This will make a failure loop that:

If test update the resource with same resource name, contract_update_create_only_property will failed due there is no createonly property change.

if test update the resource with different resource name, contract_update_non_existent_resource will failed due CfnNotUpdatableException instead of NotFound.

Let me know if you wanna me clarify something, thanks! Alex

[liyujiel]

Hey Anshika,

Thanks for reply. Could you confirm is contract test issue and won’t block our resource launch if the contract test contract_update_non_existent_resource failed? Still, by the test name and description I don’t think the input request should contains previous model.

Let me know what you think.

[PatMyron]

Also failing contract_update_non_existent_resource due to handlers being called with invalid models and expecting CfnNotFoundException as discussed in https://github.com/aws-cloudformation/cloudformation-cli/issues/527. I don’t think it makes sense to use inputs/inputs_1_invalid.json as the input to contract_update_non_existent_resource and expecting CfnNotFoundException because services should be doing model validation before actually checking resource existence