Aspect for X-Ray

Hi guys, Are there plans to create an example for this using Spring AOP for cross-cutting concerns like X-Ray? Currently we are trying to avoid many responsibilities in the code that don’t belong to the class, and for that we are using AOP. This is an example of what we are doing, but it is not working in the case of errors.

@Aspect
public class XRayAspect {

    private Logger logger = LoggerFactory.getLogger(XRayAspect.class);

    @Pointcut("@annotation(com.netflix.hystrix.contrib.javanica.annotation.HystrixCommand) && execution(* *(..))")
    public void annotationHystrixPointCut() {

    }

    @Before("annotationHystrixPointCut()")
    public void createSubsegment(JoinPoint joinPoint) {
        logger.info("---------------------- it executed before " + joinPoint);
        AWSXRay.getThreadLocal().addSubsegment(AWSXRay.beginSubsegment(joinPoint.getSignature().getName()));

    }

    @AfterThrowing(pointcut = "annotationHystrixPointCut()", throwing = "ex")
    public void addExceptiontoSubSegment(Exception ex) {
        logger.error("---------------------- it happened an error ", ex);
        AWSXRay.getCurrentSubsegment().addException(ex);
    }

    @After("annotationHystrixPointCut()")
    public void finalizeSubsegment() {

        logger.info("---------------------- it happened after ");
        AWSXRay.endSubsegment();
    }
}

I would appreciate any feedback you could provide.

[mwunderl]

I’ve added some information about multithreading to the developer guide- Using Instrumented Clients in Worker Threads Passing Segment Context between Threads in a Multithreaded Application

[paolocarrasco]

Hi @mwunderl, thanks! I finally found that the best approach to register the exceptions is by using an around aspect; before and after are useful only on annotations and metadata.