Stuck on an issue?
Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Bug: no clarity on when pull requests are allow
See original GitHub issueExpected Behaviour
In the contributing guide a clear call out of when a pull request can be make.
Current Behaviour
Pull requests are not closed citing the contributing guide
Code snippet
NA
Possible Solution
Clarify that, before a pull request can be made:
- Check if any existing issue exists
- Create new issue
- What for the issue to be approved
- Then make the pull request if you can
Steps to Reproduce
- Create a Github issue
- Create a fix for it as a Pull Request
AWS Lambda Powertools for Python version
latest
AWS Lambda function runtime
3.6
Packaging format used
Lambda Layers, PyPi
Debugging logs
NA
Issue Analytics
- State:
- Created a year ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
The Pull request build is getting failed, it is not taking new ...
We are facing the problem to get status of the build success, which was failed during creation of the a pull request.
Read more >Linking a pull request to an issue - GitHub Docs
On GitHub.com, navigate to the main page of the repository. Under your repository name, click Issues. In the list of issues, click the...
Read more >Changes Requested: The Advantages and Pitfalls of Blocking ...
Clarity in communication. It sends a signal that the reviewer feels there are sufficient issues such that the PR should not be merged...
Read more >4. Creating a Pull Request — VisIt User Manual 3.2.2 documentation
Pull Requests ( PR s) allow developers to review work before merging it into the develop branch. PRs are extremely useful for preventing...
Read more >Linking pull requests to issues - Help Center - Swarmia
Here's how to link pull requests to issues in Swarmia. ... respective issue key (e.g. CLOUD-123-foo) or use it after a slash (e.g....
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
The contribution guidelines mention it. Also, it’s stated that contribution to features is on hold until July 2022. However, I’m glad we got this small bug resolved so quickly and I just prepared code on my end because it was so present in my head 😅
ah i just realized i tagged the wrong person. oh boy. sorry
sthuber90