Allow customisation of the Authenticating component [context]
See original GitHub issueIssue and Steps to Reproduce
[I came across this issue in the context package. If it is an issue in the Redux package though I think the same applies]
Firstly, thank you very much for this component. I had started the work to do something similar myself, then found this library and decided you had done most of the hard work for me, so thank you for that 😃
I have spotted one or two issues however. You allow for customisation of the NotAuthenticated
and NotAuthorized
components, but not the Authenticating
component.
This results in a flash of French text for me when I’m trying to protect a route, which isn’t what I would want in my application.
Versions
1.1.5
Screenshots
Expected
Allow the consumer to override the Authenticating component via an authenticating
prop on the AuthenticationProvider
.
The example I looked at was for the context API, but I think this would need to be changed for all packages.
Issue Analytics
- State:
- Created 5 years ago
- Comments:11 (10 by maintainers)
Top GitHub Comments
Awesome! thank you, I will need to check it out on my computer tomorrow (I have just my phone for now), as soon as it is merged I can deploy a new version on npm if you need it.
hey @guillaumechervetaxa , thanks a lot for this incredibly helpful library, I’m having this exact same issue and the authenticating overriding is not working for me I still get the french default message, was this fix possibly lost after the big refactor?
my configuration is the following:
and then in my router
I’m using @axa-fr/react-oidc-context version ^3.1.6