question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

#1395 breaks custom config

See original GitHub issue

Summary

#1395 launched a fix that instance config may override global config, but it ignore custom configs. So it will break something we’d like to attach into the config and access in interceptor (e.g. CookieJar).

For example (https://codepen.io/anon/pen/gjZRdR?editors=1111):

const inst = axios.create();
inst.interceptors.request.use(config => {
  console.log('should be "test", actual', config.testAttr);
})
inst.get('/', {
  testAttr: 'test',
});

Context

  • axios version: v0.19.0-beta.1
  • Environment: node & chrome

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:2
  • Comments:12 (3 by maintainers)

github_iconTop GitHub Comments

5reactions
ustbhuangyicommented, Oct 23, 2018

I am looking forward to this feature😀

4reactions
edgesitecommented, Aug 14, 2018

@zcei Great point. Can we just make config.userData: any to store user data. But since it’s a regression, we still need to fix it or put it into breaking changes since it will break some old codes.

Read more comments on GitHub >

github_iconTop Results From Across the Web

SessionStateModule.cs
Custom : _store = InitCustomStore(config); break; default: break; } // We depend on SessionIDManager to manage session id _idManager ...
Read more >
Source Code for Module ganeti.config
20 21 22 """Configuration management for Ganeti 23 24 This module provides ... None and new_resource not in all_elems: 119 break 120 else:...
Read more >
Config xref - Eclipse archive
76 */ 77 public class Config { 78 private static final String[] ... 176 } 177 r.append(' '); 178 break; 179 180 default:...
Read more >
Backup Config Module - Beta - Final stage - Development ...
when all things breaks loose, everybody tries to do all the things at once ... Contribute to nethserver-backup-config development by creating an account...
Read more >
ASP.NET custom configuration section declaration breaks IIS ...
config file so that .NET can parse my custom config XML this seems to break IIS Manager's Configuration Editor. I've re-jigged the question...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found