Axios doesn't resolve/reject on network level errors (i.e. onerror)

I’ve noticed that on current chrome (unsure how other browsers treat this) axios doesn’t resolve or reject if I forget to start my api server. I believe it’s because at the network level, onload never gets called on a request, but onerror does instead, and looking at https://github.com/mzabriskie/axios/blob/master/lib/adapters/xhr.js we don’t handle onerror at all.

Any reason not to add a onerror handler? Happy to attempt a PR if not.

[nicklaw5]

I’m receiving “Network error” but server is responding with “500 Internal Server Error”.

Would be great if this error response could be more explicit for better application handling. Is this possible?

[latentflip]

So it looks like onerror doesn’t actually return an error, but a progress event. At least in the case of http://localhost:5000 when the api isn’t actually running.

Throwing that event I don’t think makes sense since it’s not even an error object. According to: http://stackoverflow.com/questions/4844643/is-it-possible-to-trap-cors-errors in at least the situation of cors errors, the actual error is not available to your JS code (just gets logged to the console).

So I guess we’re back to: either rejecting with a 0 status, or just throwing something like new Error('Unknown XHR error') thoughts?