Axios hangs when POST an empty buffer

Summary

When sending a ‘POST’ or ‘PUT’ request with an empty buffer, the promise doesn’t resolve or reject and the server doesn’t get the request. The following example demonstrates the issue:

const axios = require('axios');
const http = require('http');

const server = http.createServer((req, res) => {
  console.log('received request');
  res.writeHead(200, {'Content-Type': 'text/plain'});
  res.end('okay');
});

['listening', 'error', 'connection', 'close'].forEach(ev => {
  server.on(ev, function() {
    console.log(ev);
  });
});

server.listen(7373, async () => {
  await axios({
    url: `http://localhost:7373/hb`,
    method: 'post',
    data: Buffer.from(''),
  });

  await server.close();
});

The output for the above is:

listening
connection

and the process hangs. If you replace Buffer.from('') with just '' then it works properly and the output is:

listening
connection
request received
close

Context

• axios version: 0.18.0
• Environment: node v10.6.0

[amitzur]

Fantastic work, thank you so much 😃

[anthonygauthier]

Ruben, the person who opened the issue is also the biggest contributor of follow-redirects. So when I made my PR to the module, he was curious if it was solely related to follow-redirects or directly to Node. When he discovered that it was directly related to Node he decided to open up an issue 😃 .