Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

axios.getUri doesn't use baseURL

See original GitHub issue

Describe the bug When using https://github.com/axios/axios/pull/1712 example and adding baseURL in config, baseURL seems to not be used.

To Reproduce

const axios = require("axios");
const fakeConfig = {
  method: "post",
  url: "/user/12345",
  baseURL: "/foo"
};
console.log(axios.getUri(fakeConfig));

Expected behavior axios.getUri should return /foo/user/12345.

If this expected behavior seems right, I can work on a fix.

Environment:

Axios Version: 0.19.0
OS: Linux, Windows
Browser Chrome but also happen on Firefox and node

Issue Analytics

State:
Created 4 years ago
Reactions:6
Comments:8 (2 by maintainers)

Top GitHub Comments

8reactions

sakaritcommented, Apr 7, 2021

PR #2555 was never merged so this should still be open. The solution looks valid though, so I guess a new PR could be opened. I will try to do that later.

1reaction

friedrithcommented, Oct 16, 2019

URI may be only /user/12345 if you want to to identify the request locally to a endpoint. If you want to identifiy the request globally the endpoint URI should be including IHMO. URI specification shows examples including the protocole and the domain name https://tools.ietf.org/html/rfc3986. I think that getUri should include as many things as possible to identify the request.