Response timeout does not work as expected

The following code doesn’t work as expected (no timeout error is fired):

 client.get('/stop-writing-body-halfway', {
    timeout: 100,
 })

After a few minutes, a response is resolved despite Content-Length not having been reached and the server not explicitly closing the connection. Edit: never mind the connection is probably closed after 2 mins because of https://nodejs.org/api/http.html#http_server_timeout

My server never closes the connection and stops writing the body half way:

  const stopWritingBodyHalfway = (msg, res) => {
    res.setHeader('Content-Length', 500)
    const body = Buffer.alloc(250, 'a')
    res.write(body)
  }

Is the timeout only for the request, not for the response?

[keyworks]

In case it’s useful to anyone I’ve been patching the behaviour of timeout by using an interceptor. It uses a cancel token to cancel the request after timeout has elapsed.

const requestTimeoutInterceptor = config => {
  if (config.timeout === undefined || config.timeout === 0) {
    return config;
  }

  const source = axios.CancelToken.source();

  setTimeout(() => {
    source.cancel(`Cancelled request. Took longer than ${config.timeout}ms to get complete response.`);
  }, config.timeout);

  // If caller configures cancelToken, preserve cancelToken behaviour.
  if (config.cancelToken) {
    config.cancelToken.promise.then(cancel => {
      source.cancel(cancel.message);
    });
  }

  return { ...config, cancelToken: source.token };
};


axios.interceptors.request.use(requestTimeoutInterceptor);

[dtryon]

@olalonde Yes, exactly. At the moment, the current timeout is cleared before the response body has been completely received:

https://github.com/mzabriskie/axios/blob/master/lib/adapters/http.js#L116

The timeout gets cleared before the body stream is processed.

Instead the timeout could be be cleared later (when the body has been completely received).