timeout not cleared on error

Summary

When request is made and network error occurs, timeout is not cleared. It should be easy to replicate:

// disconnect from network before running
const axios = require('axios')
axios.get('http://github.com', { timeout: 1000 })

This script should fail and instantly quit but it will rather fail and hang for 1s

Context

• axios version: 0.18.0
• Environment: node

[wholegroup]

@JustinBeckwith I have the same issue The issue is that a request is completed in time but then the node process is hanging up during timeout before exiting. I suppose there is some issue with clearTimeout if an exception occurs (at least ENOTFOUND).

Please re-open this issue.

[cztomsik]

I’ve simply disabled wifi on my macbook, maybe it is platform specific? Also, I had different error.

node test_axios_disconnect.js 

node:61410) UnhandledPromiseRejectionWarning: Error: getaddrinfo ENOTFOUND github.com github.com:80
    at errnoException (dns.js:55:10)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:97:26)
(node:61410) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:61410) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.