Umbrella issue for v1.0.0

See original GitHub issue

Summary

This issue is an umbrella for the next release of axios. We might add more issues to the issues to fix list.

Pull Requests

Babel & Webpack 3
ESLint shared config (standard)
Migrate nodeunit to jasmine
Karma with Webpack config
Adjust specs to work with new lib interface
Substitute custom utils with lodash
Move core / adapters to ESM
Move helpers to ESM
Remove lodash helpers from utils
Move cancel module to ESM
Change external surface

Issues to fix

Build system

Utils:

https://github.com/axios/axios/issues/1298

Default instances / Config merge:

Proxy:

Default adapter / Weird aliasing:

https://github.com/axios/axios/issues/1284

Fixed due to old IE support removal:

Other candidates for 1.0.0

Parse response based on `responseType`

https://github.com/axios/axios/issues/811 (links 5 other issues with similar problem)
https://github.com/axios/axios/issues/793
https://github.com/axios/axios/issues/765
https://github.com/axios/axios/issues/724

After branches have been merged

last verification of code integrety / bugfixes
proper CHANGELOG.md
migration hints in README.md
Setup coverage via CodeCov
Investigate necessity of banner usage (could be solved via BannerPlugin)
Add a NPM script for running the TypeScript test
Remove Bower distribution
Documentation #257

When alpha has been released

mention potentially fixed issues to get some usage

Issue Analytics

State:
Created 6 years ago
Reactions:12
Comments:27 (15 by maintainers)

Top GitHub Comments

13reactions

schmodcommented, Jul 23, 2019

More conversation over in #2265.

If we aren’t making any progress on these major changes, that’s fine – let’s just bump our current version to 1.0.0, and release these changes as a 2.x branch when they’re ready. The 0.18 branch is one of the most heavily-used and well-tested pieces of software in the JavaScript ecosystem. A lack of activity isn’t necessarily a bad thing – it means stability! Let’s just formalize the status-quo and slap the 1.0.0 designation onto the current release.

7reactions

43081jcommented, Dec 26, 2019

Just came across this randomly so here’s an opinion:

This issue is 2 years old almost, you have almost certainly reached the dangling-branch/tech debt point where you should probably throw much of this away and do a better, more modern v1. Things have changed since you opened this.

For example, since you made your now-dated v1 branch, all browsers and node support ESM. you have no reason to be still writing commonjs for what is aimed at browsers. Your branch is so old it is only going to hold you back from modernising your already aged codebase.

IMO you should make v1 in ESM and have a rollup (tree-shaking enabled) bundle for older browsers (all those enterprise users using axios).

Similarly, a move to lodash seems like a step backwards. Most of what you’re pulling out of lodash exists in the platform now or is at most one line of extra code (you even pull in a trim…)

Top Results From Across the Web

Umbrella Dashboard - Error: Please enter a valid IP

This article outlines how to rectify the issue "Please enter a valid IP" when registering a network on the Umbrella dashboard.

Umbrella Projects – distillery v1.0.0 - HexDocs

Historically, exrm had poor support for umbrella projects. It worked by building a release of each application individually, which in some cases was...

umbrella-logger - npm Package Health Analysis - Snyk

The npm package umbrella-logger was scanned for known vulnerabilities and missing license, and no issues were found. Thus the package was deemed ...

DOR - Domain Ranker - Go Packages

Storage represents an interface to store and query ranks. type UmbrellaIngester ¶ added in v1.0.0. type UmbrellaIngester struct { IngesterConf }.

Cisco Umbrella Destinations - Rapid7 Extensions

Cisco Umbrella Destinations allows users to manage, block, and allow network destinations based on policies within their organization.