question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make ADS Python 3.5x/3.6x compatible

See original GitHub issue

Current branch: py2to3

Issue raised by @jcohenadad in issue #91 .

The first thing I think needs to be decided is if we want to make ADS compatible with both Python 2.7 and 3.5x/3.6x. The resources I found (below) seem to be contradicting themselves over which is preferred in the community. Dual compatibility is a bit messier to maintain in the long term; while it’s (relatively) simple to convert the code for dual compatibility, the problematic issue will then be that each dev on the future project will have to know all the little tricks needed for dual compatibility (see cheat sheet below), rather than using just Python 3’s strengths.

Most resources agree that the next step is to have comprehensive test coverage of the repo. I’ve already started working on this in branch unit_tests, which handles issue #76. I’ve also added a coveralls.io badge to the branch that gets evaluated in the Travis test, which currently asses the test coverage in that branch to be 15 % (only using the unit tests, not the integration test integrity_test.m). Once we have a test coverage closer to 100% (most people agree online that exactly 100% might be nitpicky, so >80-90% is good to aim for), then it will be easier to determine if the code functions well after being converted for 3.5/3.6x or dual 2.7/3.x.

Resources:

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

3reactions
peronecommented, May 16, 2018

Completely agree, Python 3 is the way to go, a lot of libraries are deprecating Python 2 in the following 1 or 2 years so it’s a good move.

1reaction
alzaiacommented, May 16, 2018

In my opinion, we don’t need to have dual compatibility, we could just stick to Python 3. @perone what do you think?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Installation - Ads API - Google Developers
Install the library from GitHub · Ensure that python3.6 or greater is present in your environment. · Clone the client library from GitHub:...
Read more >
Python Release Python 3.5.3
We build it ourselves, from source, on a known-clean system. ... package files compatible with the OS X Gatekeeper security feature.
Read more >
google-ads - PyPI
This project hosts the Python client library for the Google Ads API. Build Status. build-status ... Easy creation of Google Ads API service...
Read more >
Get Started Using Python with Bing Ads API - Microsoft Learn
The Bing Ads Python SDK supports Python 2.6, 2.7, and 3.3 or higher. You should install and run one of the supported versions....
Read more >
Twitter Ads API SDK for Python
Compatibility & Versioning. This project is designed to work with Python 2.7 or greater. While it may work on other version of Python,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found