Unnecessary variable loaded_fields

If no fields exist we return None and exist the bulk_update.

However later we try to get loaded_fields here. But as fields will never be None or empty we will never use evaluate the get_fields function again. So the variable loaded_fields should be unnecessary.

[arnau126]

loaded_fields is actually necessary.

At this point fields can be None or an empty list. This difference is important.

• If fields is an empty list we exit the bulk_update, as you said.
• But if fields is None we go ahead. This happens when we don’t have meta nor update_fields. In this case we don’t know which fields we have to update, and since each object could have a different set of loaded variables, we have to call get_fields for each one.

[arnau126]

[EDITED]

Thanks for the clarification! Out of curiosity at what point could it happen that meta doesn’t exist on an object?

bulk_update has an optional argument called meta. If meta is not None we will use it to update all objects in objs. But if we don’t have this “global” meta, we will use the meta from the first object.

When we don’t have this “global” meta nor update_fields is when we have to call get_fields for each object.