`Client` suffix for Swagger title and Autorest
See original GitHub issueHi @amarzavery @fearthecowboy @markcowl
I see that regularly now, new Swagger files remove the Client
suffix from the title in Swagger (recently new Storage 2015-05-01, changed from StorageManagementClient to StorageManagement). I remember having a discussion with @amarzavery where he told me that this is a good behavor, since the Swagger file can describe also the server and is not client only. BUT Autorest might add Client
to the main class name if not present.
I wanted to check with you what you think about this. Since this is the only breaking change for the new Storage file in Python, I’d like to have your feeling before release it (if Autorest adds a Client
suffix in the main class name if not present, this is not breaking). If generated clients should not have Client
and have to follow strictly the title, (and the client should be named StorageManagement for the storage example), that’s ok too (I saw the C# PR integrates the change, so it might be on purpose). Just tell me 😃
Thanks!
FYI @annatisch
Issue Analytics
- State:
- Created 7 years ago
- Comments:21 (21 by maintainers)
Top GitHub Comments
Ah, yeah, dammit. That’s Why.
The change should only affect
*Azure
generators, soGetClientName
has to be overridden in all theCodeNamer??a
implementations. (and one has to be created for the ones that don’t have one.sigh
And, now that I think deeper about it, there’s a bit more to it.
Leave it for today, If I can recover enough, I’ll be in tomorrow, and we can finish solving this right.
Sorry, I’ve been in the middle of XmlSerialization stuff. Lemme see if I can get to it this afternoon.