Incorrect enum values for boolean property with default values

When generating Azure resource schema from swagger, boolean property with default values don’t have the correct enum value set.

Example property in swagger:

        "adminUserEnabled": {
          "description": "The value that indicates whether the admin user is enabled.",
          "default": false,
          "type": "boolean"
        },

Generated property in schema:

        "adminUserEnabled": {
          "oneOf": [
            {
              "type": "boolean",
              "enum": [
                "false"
              ]
            },
            {
              "$ref": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#/definitions/expression"
            }
          ],
          "description": "The value that indicates whether the admin user is enabled."
        },

The enum set should contain both true and false boolean values rather than one string value.

The same issue is seen in other published schema such as Storage.

This is blocking us from releasing resource schema https://github.com/Azure/azure-resource-manager-schemas/pull/370

[ghost]

I don’t think there was a specific reason for this design. I most likely just hadn’t gotten around to supporting it yet. I suggest adding it in.

[olydis]

@daschult I see you initially added the above behavior here. Before touching it I wanted to quickly clarify, was there a reason for this design? The JsonSchema type doesn’t have a Default property (yet), so was this maybe just a workaround to somehow encode the information in the resulting schema? Why not model default in Swagger as default in JSON schema? 🙂