M4 4.21.0 incorrectly changes const type to string

M4 version 4.21.0

This is presumably due to the behavior change of treating single-value enums as constants.

For operation bool_putFalse, after fixing up the parameter as follows.

"parameters": [
  {
    "name": "boolBody",
    "in": "body",
    "schema" : {
      "type": "boolean",
      "enum": [false],
      "x-ms-enum": { "name": "falseConst", "modelAsString": false }
    },
    "required": true
  }
],

The schema.valueType.type has a type of SchemaType.String which is unexpected.

[jhendrixMSFT]

Verified fix is working.

[timotheeguerin]

yeah so there was 2 issues:

1. as said above it would hard code type: string when merging enums
2. if name was not provided but x-ms-enum was it would either crash(before 3.5.0) or just act like if the name is undefined and still merge it causing this issue but if x-ms-enum wasn’t there then it would use the auto generated name

Both should be fixed in the PR linked. Can you verify it works https://github.com/Azure/autorest/pull/4295#issuecomment-920451075