[Python] Autorest generates a method signature with twice the same parameter

This creates invalid code:

    def resend_request_emails(
            self, resource_group_name, name, name=None, custom_headers=None, raw=False, **operation_config):
        """Verify domain ownership for this certificate order.
        Verify domain ownership for this certificate order.
        :param resource_group_name: Name of the resource group to which the
         resource belongs.
        :type resource_group_name: str
        :param name: Certificate order name
        :type name: str
        :param name: Name of the object.
        :type name: str

Based on the docstring, it seems there is two differents objects that wants the same parameter name, but obviously it not possible.

Generated with latest Autorest (20170114) and WebApp composite client. Method is here:

       "parameters": [
          {
            "$ref": "#/parameters/resourceGroupNameParameter"
          },
          {
            "name": "name",
            "in": "path",
            "description": "Certificate order name",
            "required": true,
            "type": "string"
          },
          {
            "name": "nameIdentifier",
            "in": "body",
            "description": "Email address",
            "required": true,
            "schema": {
              "$ref": "#/definitions/NameIdentifier"
            }
          },
...
    "NameIdentifier": {
      "description": "Identifies an object.",
      "type": "object",
      "properties": {
        "name": {
          "description": "Name of the object.",
          "type": "string"
        }
      }
    },

Python code is here.

Autorest cmd line: mono /tmp/tmpwl8glpmr/autorest/tools/AutoRest.exe -i /git-restapi/arm-web/compositeWebAppClient.json -o /tmp/tmpwl8glpmr/compositeWebAppClient.json -AddCredentials True -CodeGenerator Azure.Python -Header MICROSOFT_MIT_NO_VERSION -Modeler CompositeSwagger -Namespace azure.mgmt.web -PackageVersion 0.31.0 -ft 2

FYI @annatisch @fearthecowboy @yugangw-msft

[fearthecowboy]

Ah. Ok, that’ll help.

Back on it!

[fearthecowboy]

This would have been handled in the core; duplicate names get disambiguated pretty early.

I think that it’s sneaking by because of auto flattening which happens later. (which happens quite a bit later. )

I’m going to have to debug into this and see why it’s not getting caught when the params are added back into the collection.