python: configuration field for LRO polling interval is not correct

The generated code for client assumes long_running_operation_retry_timeout, but its operation assumes long_running_operation_timeout

[annatisch]

Hi @yugangw-msft, thanks for spotting this!

After discussing possible fixes with @lmazuel, we’re thinking that we will remove this (and other options) from the constructor of the client, so these will need to be set specifically on client.config like you are currently doing in your workaround.

This should help us reduce the size of the generated code.

For example, the generated code will become:

class ComputeManagementClientConfiguration(AzureConfiguration):
    def __init__(self, credentials, subscription_id, base_url=None, filepath=None):

        if credentials is None:
            raise ValueError("Parameter 'credentials' must not be None.")
        if subscription_id is None:
            raise ValueError("Parameter 'subscription_id' must not be None.")
        if not isinstance(subscription_id, str):
            raise TypeError("Parameter 'subscription_id' must be str.")
        if not base_url:
            base_url = 'https://management.azure.com'

        super(ComputeManagementClientConfiguration, self).__init__(base_url, filepath)

        self.add_user_agent('computemanagementclient/{}'.format(VERSION))
        self.add_user_agent('Azure-SDK-For-Python')

        self.credentials = credentials
        self.subscription_id = subscription_id

class ComputeManagementClient(object):
    def __init__(self, credentials, subscription_id, base_url=None, filepath=None):

        self.config = ComputeManagementClientConfiguration(credentials, subscription_id, base_url, filepath)
        self._client = ServiceClient(self.config.credentials, self.config)

        client_models = {k: v for k, v in models.__dict__.items() if isinstance(v, type)}
        self._serialize = Serializer(client_models)
        self._deserialize = Deserializer(client_models)

And this would be consumed and configured like so:

client = ComputeManagementClient(creds, sub_id, base_url=service_url)
client.config.generate_request_id = False  # Default is True
client.config.accept_language = 'de-DE'  # Default is 'en-US'
client.config.long_running_operation_timeout = 5  # Default is 30

This is a breaking change - so will be rolled out into the next major version of the Azure SDK for Python.

What do you think?

Cheers, Anna

[lmazuel]

@fearthecowboy indeed already fixed