rush update fails

Before filling a bug

• have you checked the faq for known issues.
• have you checked existing issues

Describe the bug

I’m following the instructions in docs/internal/development.md to set up for development in autorest.

I did a fresh install of rush:

npm install -g @microsoft/rush

Then I ran rush update but this fails:

node_modules/.pnpm/tree-sitter@0.19.0/node_modules/tree-sitter: Running install script, failed in 5.5s
.../node_modules/tree-sitter install$ prebuild-install || node-gyp rebuild
│ prebuild-install WARN install No prebuilt binaries found (target=16.14.2 runtime=node arch=arm64 libc= platform=darwin)
│ gyp info it worked if it ends with ok
│ gyp info using node-gyp@7.1.2
│ gyp info using node@16.14.2 | darwin | arm64
│ gyp info find Python using Python version 3.9.10 found at "/opt/homebrew/opt/python@3.9/bin/python3.9"
│ (node:92282) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
│ (Use `node --trace-deprecation ...` to show where the warning was created)
│ gyp info spawn /opt/homebrew/opt/python@3.9/bin/python3.9
│ gyp info spawn args [
│ gyp info spawn args   '/Users/mikekistler/.rush/node-v16.14.2/pnpm-5.16.0/node_modules/pnpm/dist/node_modules/node-gyp/gyp/gyp_main.py',
│ gyp info spawn args   'binding.gyp',
│ gyp info spawn args   '-f',
│ gyp info spawn args   'make',
│ gyp info spawn args   '-I',
│ gyp info spawn args   '/Users/mikekistler/Projects/Azure/autorest/common/temp/node_modules/.pnpm/tree-sitter@0.19.0/node_modules/tree-sitter/build/config.gypi',
│ gyp info spawn args   '-I',
│ gyp info spawn args   '/Users/mikekistler/.rush/node-v16.14.2/pnpm-5.16.0/node_modules/pnpm/dist/node_modules/node-gyp/addon.gypi',
│ gyp info spawn args   '-I',
│ gyp info spawn args   '/Users/mikekistler/Library/Caches/node-gyp/16.14.2/include/node/common.gypi',
│ gyp info spawn args   '-Dlibrary=shared_library',
│ gyp info spawn args   '-Dvisibility=default',
│ gyp info spawn args   '-Dnode_root_dir=/Users/mikekistler/Library/Caches/node-gyp/16.14.2',
│ gyp info spawn args   '-Dnode_gyp_dir=/Users/mikekistler/.rush/node-v16.14.2/pnpm-5.16.0/node_modules/pnpm/dist/node_modules/node-gyp',
│ gyp info spawn args   '-Dnode_lib_file=/Users/mikekistler/Library/Caches/node-gyp/16.14.2/<(target_arch)/node.lib',
│ gyp info spawn args   '-Dmodule_root_dir=/Users/mikekistler/Projects/Azure/autorest/common/temp/node_modules/.pnpm/tree-sitter@0.19.0/node_modules/tree-sitter',
│ gyp info spawn args   '-Dnode_engine=v8',
│ gyp info spawn args   '--depth=.',
│ gyp info spawn args   '--no-parallel',
│ gyp info spawn args   '--generator-output',
│ gyp info spawn args   'build',
│ gyp info spawn args   '-Goutput_dir=.'
│ gyp info spawn args ]
│ gyp info spawn make
│ gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
│   CC(target) Release/obj.target/tree_sitter/vendor/tree-sitter/lib/src/lib.o
│   LIBTOOL-STATIC Release/tree_sitter.a
│   CXX(target) Release/obj.target/tree_sitter_runtime_binding/src/binding.o
│ In file included from ../src/binding.cc:1:
│ In file included from /Users/mikekistler/Library/Caches/node-gyp/16.14.2/include/node/node.h:63:
│ In file included from /Users/mikekistler/Library/Caches/node-gyp/16.14.2/include/node/v8.h:30:
│ /Users/mikekistler/Library/Caches/node-gyp/16.14.2/include/node/v8-internal.h:492:38: error: no template named 'remove_cv_t' in namespace 'std'; did you mean 'remove_cv'?
│             !std::is_same<Data, std::remove_cv_t<T>>::value>::Perform(data);
│                                 ~~~~~^~~~~~~~~~~
│                                      remove_cv
│ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/type_traits:710:50: note: 'remove_cv' declared here
│ template <class _Tp> struct _LIBCPP_TEMPLATE_VIS remove_cv
│                                                  ^
│ 1 error generated.
│ make: *** [Release/obj.target/tree_sitter_runtime_binding/src/binding.o] Error 1
│ gyp ERR! build error 
│ gyp ERR! stack Error: `make` failed with exit code: 2
│ gyp ERR! stack     at ChildProcess.onExit (/Users/mikekistler/.rush/node-v16.14.2/pnpm-5.16.0/node_modules/pnpm/dist/node_modules/node-gyp/lib/build.js:194:23)
│ gyp ERR! stack     at ChildProcess.emit (node:events:526:28)
│ gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)
│ gyp ERR! System Darwin 20.6.0
│ gyp ERR! command "/opt/homebrew/Cellar/node@16/16.14.2/bin/node" "/Users/mikekistler/.rush/node-v16.14.2/pnpm-5.16.0/node_modules/pnpm/dist/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
│ gyp ERR! cwd /Users/mikekistler/Projects/Azure/autorest/common/temp/node_modules/.pnpm/tree-sitter@0.19.0/node_modules/tree-sitter
│ gyp ERR! node -v v16.14.2
│ gyp ERR! node-gyp -v v7.1.2
│ gyp ERR! not ok 
└─ Failed in 5.5s
node_modules/.pnpm/jsonpath@1.0.0/node_modules/jsonpath: Running postinstall script, done in 81ms
 ERROR  Command failed with exit code 1.

The command failed:
 /Users/mikekistler/Projects/Azure/autorest/common/temp/pnpm-local/node_modules/.bin/pnpm install --store /Users/mikekistler/Projects/Azure/autorest/common/temp/pnpm-store --no-prefer-frozen-lockfile
ERROR: Error: The command failed with exit code 1

Expected behavior

rush update works.

[mikekistler]

That fixes it!

[timotheeguerin]

Ok I have been able to repro. This seems to be an issue with node 16 and building native dependencies. Version 0.20.0 of tree-sitter should have fixed it. Can you try going into packages/tools/compare/package.json and updating the version of tree-sitter to 0.20.0