[Track1] User Agent Can be Override

I do a test to try to override the Use-Agent in Track1 JS SDK, and it succeed. The Following is the details: Codes:

const msRestNodeAuth = require("@azure/ms-rest-nodeauth");
const { ComputeManagementClient } = require("@azure/arm-compute");

msRestNodeAuth.interactiveLogin().then((creds: any) => {
    const client = new ComputeManagementClient(creds, "eece696d-f03b-47a5-9e4c-157d7ad85b20", {
        userAgent: "aaaaaaaaaaaaaaaaaaaaaaaa"
    });
    client.operations.list().then((result: any) => {
        console.log("The result is:");
        console.log(result);
    });
}).catch((err: any) => {
    console.error(err);
});

Requests Header captured by fiddler:

I think the user-agent should only be extended, instead of overrode. Please check it.

[sarangan12]

Code complete with PR https://github.com/Azure/autorest.typescript/pull/1033. Will be released tomorrow (06/15)

[sarangan12]

I have synched up with other SDK owners and confirmed that they are infact appending the user provided user-agent value (prepending in case of Track 2). So, I have to do the same for Track 1 & Track 2 SDK Generators.

For Track 1 SDK Generator, I am planning to use the user-agent value in the following format: azure-sdk-for-js/<package_name>/<package_version> ms-rest-js/<package_version><platform_info>. An example User-Agent String will be azure-sdk-for-js/@azure/arm-compute/11.2.0 ms-rest-js/10.0.0 (Ubuntu; Linux x86_64; rv:34.0). To this, the user provided value will be appended.

[Note: There is already a default user agent in ms-rest-js. But, that has only ms-rest-js/<version>/<platformspecificdata> which is not sufficient. The above format, that I suggested was based on the Python’s recommendation as mentioned here]

For Track 2, the situation is similar to Track 1 in case of core-http. Once, I complete the implementation, I will update this issue.