[API review] Auto-gen code for file

• Rename FileHTTPHeader -> FileHttpHeaders

• In FileHTTPHeader, the API has pattern of getFile*(), however, in FileProperties, it is get*(), do we want to align those? Drop the File from getter and setter?

• Is it necessary to name this as Ntfs to inform the user of the file system format? Can this just be FileAttributes?

• Can user set the last modified time? Isn’t it set in the service when the user updates something? ShareProperties

• In Range, since end is optional, should this return Long instead of long?

• FileProperty is not used anywhere and we have a hand craft FileProperties. Do we still need the FileProperty?

[sima-zhu]

Regarding: FileProperty is not used anywhere and we have a hand craft FileProperties. Do we still need the FileProperty?

The response body of API to “List files and directories” includes an array describing each file, such a description contains two fields - file name and size of the file. The “FileProperty” is defined in swagger to hold this“file size”, I believe it’s designed in this way to accommodate more properties in future (e.g. last modified time of file).

The “FileProperties” is something we wrote in our convenience layer to represents result of - Get File property API, service returns properties through headers and in convince layer we move them in this model.

So, FileProperty and FileProperties are different. We cannot remove any one of them.

Update Oct/15: This is NOP, see above comments.

[sima-zhu]

Regarding: In Range, since end is optional, should this return Long instead of long?

In request, service allows us to put null value for FileRange::end property. Refer Rest API doc. In response, service always return the end of the range. It is required field.

So we’d better to leave as it is.

Update Oct/15: This is NOP, see above comments.