[BUG] Make sure all RestTemplate are managed by AadRestTemplateCreator

Context

To support connect Azure AD via proxy, AadRestTemplateCreator is used to create all RestTempalte that used to send http request to Azure AD endpoint or Graph endpoint. But some RestTemplate are not created by AadRestTemplateCreator. For example: #31233

Goal

Find all RestTemplate used to send http request to Azure AD endpoint or Graph endpoint, make sure they are all created by AadRestTemplateCreator.

Solution

(Just potential solution. update is possible when this task started and find something new)

• Fix #31233 : 1 day
• ~Search all new RestTemplate in spring-security-oauth2 related package. Make sure all related RestTemplate are all created by AadRestTemplateCreator. 1 day~ Debug sample app (aad-web-application), add break point at RestTemplate’s constructor. Make sure all RestTemplate instance is (1) created by AadRestTemplateCreator or (2) will be replaced by AadRestTemplateCreator created instance.
• Setup a proxy and test this feature. Fix potential problems. 2 day

Toal man-day = 1 + 1 + 2 = 4

[chenrujun]

Confirmed that after #31597, proxy setting will take effect for all http requests sent by RestTemplate.

Here is the list of http request urls:

Azure AD web application

• https://login.microsoftonline.com/{tenant-id}/oauth2/v2.0/token
• https://login.microsoftonline.com/{tenant-id}/discovery/v2.0/keys
• https://graph.microsoft.com/v1.0/me/memberOf
• https://graph.microsoft.com/v1.0/me/memberOf?$skiptoken=…
• https://graph.microsoft.com/oidc/userinfo

Azure AD resource-server

• https://login.microsoftonline.com/{tenant-id}/discovery/v2.0/keys

Azure AD B2C web application

• https://{directory-name}.b2clogin.com/{directory-name}.onmicrosoft.com/oauth2/v2.0/token?p={flow-name}
• https://{directory-name}.b2clogin.com/{directory-name}.onmicrosoft.com/discovery/v2.0/keys?p={flow-name}

Azure AD B2C resource-server

• https://login.microsoftonline.com/{tenant-id}/v2.0/.well-known/openid-configuration
• https://login.microsoftonline.com/{tenant-id}/discovery/v2.0/keys

Closing this issue.

[chenrujun]

Record of this step:

• Debug sample app (aad-web-application), add break point at RestTemplate’s constructor. Make sure all RestTemplate instance is (1) created by AadRestTemplateCreator or (2) will be replaced by AadRestTemplateCreator created instance.

Here are some examples:

1. RestTemplate createc by AadRestTemplateCreator

   

2. RestTemplate not createc by AadRestTemplateCreator, but will be replaced by AadRestTemplateCreator created instance.

   

   

   

   

   

3. DefaultOAuth2UserService’s RestTemplate is not created by AadRestTemplateCreator. But it will not be executed. Need more investigation about this. Issue created: https://github.com/Azure/azure-sdk-for-java/issues/31546