[QUERY] AzureJacksonAdapter fails to serialize map with key of resource ID

Query/Question We use AzureJacksonAdapter to serialize the VirtualMachineInner. It doesn’t work as expected when parsing the map inside the property of identity.

Why is this not a Bug or a feature Request? Not sure if we missed adding some specific annotation in the object.

Code snippet to reproduce:

        VirtualMachineInner inner = new VirtualMachineInner();
        VirtualMachineIdentity identity = new VirtualMachineIdentity();
        Map<String, VirtualMachineIdentityUserAssignedIdentities> map = new HashMap<>();
        map.put("/subscriptions/0-0-0-0-0/resourcegroups/0/providers/Microsoft.ManagedIdentity/userAssignedIdentities/0",
                new VirtualMachineIdentityUserAssignedIdentities());
        identity.withType(ResourceIdentityType.SYSTEM_ASSIGNED_USER_ASSIGNED);
        identity.withUserAssignedIdentities(map);
        inner.withIdentity(identity);

If we only serialize identity, we will get what we need

{
  "type": "SystemAssigned, UserAssigned",
  "userAssignedIdentities": {
    "/subscriptions/0-0-0-0-0/resourcegroups/0/providers/Microsoft.ManagedIdentity/userAssignedIdentities/0": {}
  }
}

But the actual what we get from inner is

  "identity": {
    "type": "SystemAssigned, UserAssigned",
    "userAssignedIdentities": {
      "/subscriptions/0-0-0-0-0/resourcegroups/0/providers/Microsoft": {
        "ManagedIdentity/userAssignedIdentities/0": {}
      }
    }
  },

Setup (please complete the following information if applicable):

• OS: Windows
• IDE : IntelliJ
• Version of the Library used

Information Checklist Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

• Query Added
• Setup information Added

[alzimmermsft]

Investigated with the help of @jianghaolu and we determined the reason that it is splitting the map key on . is due to VirtualMachineIdentity being final (https://github.com/Azure/azure-libraries-for-java/blob/vnext-compute-fix-tests/azure-mgmt-compute/src/main/java/com/azure/management/compute/VirtualMachineIdentity.java#L18), this triggers FlatteningSerializer to treat the Map property differently. It will early out on this line instead of hitting this code path.

A quick short term fix would be removing final from VirtualMachineIdentity.

[samvaity]

Fixed with ##22591 to allow flattening of static and final variables.