[Cosmos DB] Bug in "Delete Bulk" operation with "undefined" partition key value

• Package Name: @azure/cosmos
• Package Version: 3.9.1
• Operating system: macOS
• nodejs
  • version: 10.16.3
• browser
  • name/version:
• typescript
  • version:
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • SDK API docs on https://docs.microsoft.com

Describe the bug When performing the “delete” bulk operation with “undefined” partition key value, the bulk operation fails with the following error:

TypeError: Cannot read property 'replace' of undefined
    at getPartitionKeyToHash (/Users/xxx/Projects/yyy/app/node_modules/@azure/cosmos/dist/index.js:919:38)
    at /Users/xxx/Projects/yyy/app/node_modules/@azure/cosmos/dist/index.js:5483:39
    at Array.forEach (<anonymous>)
    at Items.<anonymous> (/Users/xxx/Projects/yyy/app/node_modules/@azure/cosmos/dist/index.js:5480:22)
    at Generator.next (<anonymous>)
    at fulfilled (/Users/xxx/Projects/yyy/app/node_modules/@azure/cosmos/node_modules/tslib/tslib.js:111:62)
    at processTicksAndRejections (internal/process/task_queues.js:89:5)

I believe this is happening because of the following lines of code:

    function getPartitionKeyToHash(operation, partitionProperty) {
        const toHashKey = hasResource(operation)
            ? operation.resourceBody[partitionProperty]
            : operation.partitionKey.replace(/[\[\]\"\']/g, "");
        // We check for empty object since replace will stringify the value
        // The second check avoids cases where the partitionKey value is actually the string '{}'
        if (toHashKey === "{}" && operation.partitionKey === "[{}]") {
            return {};
        }
        return toHashKey;
    }

According to the documentation here, undefined value is valid for the partition key.

[zfoster]

that’s right and needs resolving. I’ll reopen this issue and mark as bug since it’s not only erroneous documentation (and in fact, we may want undefined to just work the same way as {})

[zfoster]

Intended to close this as we’ve released the quality of life fix