generateSasUrl url-encodes slashes in blob name, breaks url

• Package Name: @azure/storage-blob
• Package Version: 12.4.0
• Operating system: Linux lubuntu 18.04
• nodejs
  • version: 14.15.4

Describe the bug generateSasUrl url-encodes slashes in blob name, resulting in broken url

To Reproduce Steps to reproduce the behavior:

1. upload a blob with name: foo/123/bar.jpg
2. generate a SAS url using @azure/storage-blob:

const { BlobServiceClient, StorageSharedKeyCredential, BlobSASPermissions } = require('@azure/storage-blob');
const config = {container: 'test', account: 'foo', accountKey: '...'}; // using a Storage account access key

const sharedKeyCredential = new StorageSharedKeyCredential(config.account, config.accountKey);
const blobServiceClient = new BlobServiceClient(`https://${config.account}.blob.core.windows.net`, sharedKeyCredential);
const containerClient = blobServiceClient.getContainerClient(config.container);
const blobClient = containerClient.getBlobClient('foo/123/bar.jpg');
console.log(
  blobClient.generateSasUrl({
    permissions: new BlobSASPermissions({ read: true }),
    expiresOn: new Date(Date.now() + 86400 * 1000),
  })
);

outputs

Promise {
  'https://foo.blob.core.windows.net/test/foo%2F123%2Fbar.jpg?sv=2020-04-08&se=2021-01-23T08%3A39%3A24Z&sr=b&sig=i....%2BZU%3D'
}

where slashes are url-encoded as “%2F”, which makes link not work properly

Expected behavior In comparison, it’s working from Azure portal dashboard as expected, if I click on the blob file and then click “Generate SAS token and URL” the url is well formatted and they work if I request them:

https://foo.blob.core.windows.net/test/foo/123/bar.jpg?sp=r&st=2021-01-22T08:26:41Z&se=2021-01-22T16:26:41Z&spr=https&sv=2019-12-12&sr=b&sig=mlulH.....HeYTqE%3D

[ljian3377]

The real cause is you were not correctly constructing a permission with new BlobSASPermissions({ read: true }). We may consider to support this way. But for now, you should use either

const permission = BlobSASPermissions.from({ read: true })

or

const permission = BlobSASPermissions.parse('r')

Note that both parse() and from() are static methods, so you don’t need to call it with the new operator.

[ljian3377]

You are welcome. Will close this issue now. Feel free to re-open it if any help is needed from us regarding it.